fix: reset hide timer based on PanGestureHandler state

seniv / react-native-notifier

Fast and simple in-app notifications for React Native

MIT License

1.05k stars 60 forks source link

Closed diegolmello closed 4 years ago

diegolmello commented 4 years ago

Notifier keeps showing after hide timer expires

Tap on Error Alert from example app
Hold the notification and swipe slightly to the top (just enough to trigger onHandlerStateChange)
Wait 3 seconds
Release it
The notification won't hide anymore

Do all steps above and it should reset the timer after the notification is released

seniv commented 4 years ago

Hi @diegolmello, it's a good catch! Thank you for the fix. I left one comment

diegolmello commented 4 years ago

@seniv Done! Thanks :)

seniv commented 4 years ago

The fix just released at version 1.3.1 🤗

diegolmello commented 4 years ago

@seniv Thanks! You have a lovely lib here and we're going to use it :)

seniv commented 4 years ago

Wow, that's cool! I am very glad that you have decided to use this library🙌 @diegolmello