search

seniv / react-native-notifier

Fast and simple in-app notifications for React Native
MIT License
1.05k stars 60 forks source link

Feature request: Allow to override animation values #28

Closed angel-rs closed 3 years ago

angel-rs commented 3 years ago

Hi, thanks for creating this awesome library :)

I'm building an app for mobile/web using expo. Currently experimenting with having a different config for showing notifications on desktop, e.g: making it appear from the bottom instead from the top of the screen.

In order to do so, I think it would require to:

  1. Override this.hiddenComponentValue here. That is to set it to be on the bottom of the screen
  2. Pass a custom value to showNotificationto override the Animation's `MAX_TRANSLATE_Y. That is to make it move upwards, instead of downwards.

Not sure if I'm missing anything, if that sounds reasonable I can try land a PR myself, but would be good to get some feedback on this before doing so.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.