search

senjuhashirama / pugixml

Automatically exported from code.google.com/p/pugixml
0 stars 0 forks source link

find_child_by_attribute can cause assertion failure in strequal #180

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This happens if the attribute value is set to an empty string at runtime (in 
which case a->value is NULL in inner loop of find_child_by_attribute)

patch against github version (as of Sept 28, 2012) with test case and fix is 
attached

Best Regards,

Matt White

Original issue reported on code.google.com by matt.r.w...@gmail.com on 28 Sep 2012 at 6:19

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for the bug report!

I've fixed this in the trunk of SVN repo and updated hg/git mirrors. I've had 
to modify your patch a bit to account for empty values.

Original comment by arseny.k...@gmail.com on 29 Sep 2012 at 7:00