senkenn / sqlsurge

Visual Studio Code extension for SQL language server
https://marketplace.visualstudio.com/items?itemName=senken.sqlsurge
MIT License
18 stars 0 forks source link

Feature Question: Restart sqls server #73

Closed PorcoRosso85 closed 2 months ago

PorcoRosso85 commented 4 months ago

Hi.

Does yours have this feature?

OR Do you have plan to add this?

senkenn commented 4 months ago

Hi @PorcoRosso85 sqlx server? you mean sqls?

PorcoRosso85 commented 4 months ago

Hi @PorcoRosso85 sqlx server? you mean sqls?

Sorry.

Yes, as you think. I wanted to ask 'sqls'.

senkenn commented 4 months ago

I think this feature would be even more useful because we will no longer need to Reload Window. Reload Window take a long time and it's annoying to wait for it. I think a better way to achieve this would be to create a dedicated vscode command or monitor the sqls config file. Contributions are welcome.

senkenn commented 4 months ago

Thanks @PorcoRosso85 for the feature suggestion.

PorcoRosso85 commented 2 months ago

Hi. I'm following updates of this extension.

In addition to this question, how about restarting 'sqlsurge' itself? Do you have any plan?

senkenn commented 2 months ago

@PorcoRosso85 OK! I'll implement to restart sqls language server.

PorcoRosso85 commented 2 months ago

Thanks.

Also sqlsurge? not only sqls

senkenn commented 2 months ago

I guess sqlsurge does not need to restart. sqlsurge does not use global storage or such as cache. If it looks like sqlsurge will need to be restarted, I'll consider it again.

PorcoRosso85 commented 2 months ago

Sorry if I misunderstand. I was thinking that we should restart sqlsurge to check whether sqlsurge has connected or searched sqls successfully. We don't have to restart?

senkenn commented 2 months ago

@PorcoRosso85 You are not wrong.

we should restart sqlsurge to check whether sqlsurge has connected or searched sqls successfully.

It's Yes, we do not have any methods to check that except for Reload Window. I am trying to implement a VS Code command that immediately checks whether sqls has connected successfully.

senkenn commented 2 months ago

now you can get sqlsurge.restartSqlLanguageServer command in v0.5.8 :rocket: