search

senko / python-video-converter

Python Video Converter (ffmpeg wrapper)
468 stars 191 forks source link

Development #33

Closed cytec closed 10 years ago

cytec commented 11 years ago

added basic subtitle support (mainly -scodec copy command) and also a map option to map the whole stream as of http://ffmpeg.org/ffmpeg.html#Main-options

-map 0 gives us the option to copy all audio/video and subtitle streams with the given settings :)

senko commented 10 years ago

Hey @cytec thanks for the subtitle handling code! I've got a couple of minor comments, otherwise looks great! If you could just address the issues I commented about, I'll be happy to merge.

cytec commented 10 years ago

@senko fixed the comments and also added some new codecs and reordered the codecs for better overview. seems like all tests are passing now.

cytec commented 10 years ago

@senko any news on this?

senko commented 10 years ago

@cytec oops sorry for dropping the ball on this one. Reviewed the new commits, looks great, thanks!

cytec commented 10 years ago

@senko Thanks :)