search

senko / python-video-converter

Python Video Converter (ffmpeg wrapper)
468 stars 191 forks source link

Sickbeard-mp4-automator merge #54

Open mdhiggins opened 9 years ago

mdhiggins commented 9 years ago

Updated the modifications made in Sickbeard mp4 automator to the latest version of python-video-converter in such a way that they are backwards compatible with prior version unlike my last pull attempt.

Changes made here add the ability to output files with multiple audio and subtitle tracks taking advantage of FFMPEGs -map function. Can pull from multiple or single sources. to create complex files with different tracks.

Options are presented as nested dictionaries now but previously used style dictionaries are still compatible.

Tests will need to be updated

mdhiggins commented 9 years ago

Looks like a lot of my changes from the pull request I made a year ago have found their way into the project which is great. I wanted to update my script to use the latest version of your converter but I still need the greater level of functionality. This time however, I made some changes so that I don't break backwards compatibility. In my (albeit limited) testing my script is working as it previously did and I'm also able to use the readme example (using the original style options) with no problems either.

cytec commented 9 years ago

nice! +1

mdhiggins commented 9 years ago

Updated the script some more to pass the various tests. had to modify some of the tests due to the way command line parameters being generated were different but its passing now.

mdhiggins commented 9 years ago

Any info on this? Any additional changes you require?