senlin / classic-editor-addon

This free "Classic Editor Addon" plugin makes sure that Gutenberg cannot be accidentally activated even while the "Classic Editor" plugin is active.
GNU General Public License v3.0
20 stars 5 forks source link

Why are only styles removed and no scripts? #15

Closed adekrijger closed 1 year ago

adekrijger commented 1 year ago

I saw that only styles are removed and I'd like to remove everything connected to blocks. Probably you have done this for a reason. Can you please share why?

senlin commented 1 year ago

Please elaborate

possible Duplicate of #14 (or related)?

adekrijger commented 1 year ago

Hi Pieter,

all kinds of javascript is also added by blocks if I'm not wrong?

Why are those not removed?

Met vriendelijke groet / Kind regards,

Albert de Krijger

Op 8-2-2023 om 13:16 schreef Pieter Bos:

Please elaborate

— Reply to this email directly, view it on GitHub https://github.com/senlin/classic-editor-addon/issues/15#issuecomment-1422503993, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5YBOH4YWSQJAMM3AKTEZKDWWOFC7ANCNFSM6AAAAAAUVE667Y. You are receiving this because you authored the thread.Message ID: @.***>

senlin commented 1 year ago

It would be helpful if you were able to point out exactly which scripts are still showing after activating the Classic Editor + plugin.

adekrijger commented 1 year ago

all in the print screen, the print screen is after activating

Met vriendelijke groet / Kind regards,

Albert de Krijger

Op 8-2-2023 om 16:34 schreef Pieter Bos:

It would be helpful if you were able to pint out exactly which scripts are still showing after activating the Classic Editor + plugin.

— Reply to this email directly, view it on GitHub https://github.com/senlin/classic-editor-addon/issues/15#issuecomment-1422803590, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5YBOH2T75YWLOMBRUMCMQ3WWO4IJANCNFSM6AAAAAAUVE667Y. You are receiving this because you authored the thread.Message ID: @.***>

senlin commented 1 year ago

Ok thanks for making have another good look at things.

Turns out that the function to remove the lot needs to be called now with enqueue_block_assets instead of wp_enqueue_scripts.

just released new version, will update on WP soon too

joldnl commented 1 year ago

@senlin I believe @adekrijger tries to explain that javascript assets for the block editor are still enqueued and loaded on both front end and back end, as opposed to the styles assets that are dequeued or deregistered in the current situation of the plugin

senlin commented 1 year ago

Thank you @joldnl - I tried to get someone to show me concretely which scripts are being loaded. Post a screenshot so I can see please.

senlin commented 1 year ago

closing this as there are no scripts in my opinion; feel free to re-open with screenshot of actual scripts found.

joldnl commented 1 year ago

@senlin Sure, just a quick look at the scripts loaded for woocommerce blocks:

wp-content/plugins/woocommerce/packages/woocommerce-blocks/build/wc-blocks-registry.js
wp-content/plugins/woocommerce/packages/woocommerce-blocks/build/wc-blocks-middleware.js
wp-content/plugins/woocommerce/packages/woocommerce-blocks/build/wc-blocks-data.js
wp-content/plugins/woocommerce/packages/woocommerce-blocks/build/blocks-checkout.js
senlin commented 1 year ago

Thanks, not sure where this is a screenshot of though as it doesn't show any other information...

I would like to show you this vanilla setup, so you can see that there are no scripts being loaded. The only plugins installed there are WooCommerce and the Classic Editor + plugin. It uses the default Storefront theme (which does seem to add some blocks styling).

I don't want to make this into a yes/no game, but for me to address this as an issue, you will need to help me understand it and provide as much information as possible.

senlin commented 1 year ago

Could it perhaps be that you have a separate plugin called WooCommerce Blocks installed?