search

sennetconsortium / portal-ui

0 stars 1 forks source link

Investigate if `display_subtype` is still required #1550

Closed maxsibilla closed 1 month ago

maxsibilla commented 1 month ago

This field is generated in the Entity API via a trigger for the /documents endpoint and is still used in the Portal. We need to verify if this is redundant or if we need to modify how its being generated/what it returns.

libpitt commented 1 month ago

Based on comments in entity-api under the trigger get_display_subtype. Looks like it is still needed. https://github.com/sennetconsortium/entity-api/blob/main/src/schema/schema_triggers.py#L1482-L1489

maxsibilla commented 1 month ago

Yes we do so no action will be taken