search

senny / cabbage

get the maximum out of emacs
http://senny.github.com/cabbage/
156 stars 21 forks source link

M-x is broken if ergonomic disabled #146

Closed weiqiyiji closed 12 years ago

weiqiyiji commented 12 years ago

rect-mark bundle define "M-x" for other command

senny commented 12 years ago

this relates to #108. I think the binding API will not be ready for some time. We need a better way to prevent such conflicts. I suggest moving the specific bindings into the ergonomic bundle. Then we can use cabbage-bundle-active-p to check wether the specific bundles are activated to add the bindings.

@jone thoughts or a better idea?

jone commented 12 years ago

Well, that's the old binding problem. In fact (global) bindings should not be defined in bundles (meaning: ergonomic should not be a bundle). Since #108 will not be solved in a timely manner I think moving the binding is best for now, altough it is finghting symptoms. We need to fix the concept tough...

senny commented 12 years ago

@tonini can you move the bindings from the rect-mark bundle into the ergonomic bundle as described above and open a PR?

tonini commented 12 years ago

@senny sure, I will do it.