search

senny / cabbage

get the maximum out of emacs
http://senny.github.com/cabbage/
156 stars 21 forks source link

Add bundle ido-ubiquitous #148

Closed weiqiyiji closed 11 years ago

senny commented 12 years ago

Thanks for the contribution. We once used a code snippet to get a similar result but it didn't work with Emacs 24. I haven't checked if there are new ways to get ido everywhere and ido-ubiquitous looks very interesting.

I don't think this should be a bundle though. We want cabbage to be opinionated and I think ido is a nice tool, which should be used globally. I'll have a look at ido-ubiquitous and if it works out I suggest we activate it in the completion bundle where we currently activate ido-everywhere

@weiqiyiji could you update the PR so that there is no ido-ubiquitous bundle and that the mode is activated in the completion bundle?

@jone what's your opinion?

weiqiyiji commented 12 years ago

OK, I'll pull a new request later

senny commented 12 years ago

@weiqiyiji you don't need to reopen a new PR. you can just adjust your current branch to match and then push that state on the server with git push -f and the PR will automatically reflect your changes.

jone commented 12 years ago

ido-ubiquitous patches completing-read. This may break some stuff (e.g. python/plone bundles have lots of completing-read). It needs to be tested before merging. I'm also wondering how it affects M-t with a lot of files? (This was a problem before, as far as I remember).

In lack of an emacs I'm not able to test it in the next few weeks. Maybe @phgross could test the branch, especially python / plone stuff?

weiqiyiji commented 12 years ago

@jone I've used ido-ubiquitous in emacs 23 and 24 for months (In windows, mac, ubuntu), I don't encounter any problem with this, so can you tell me exactly what's your concern?

jone commented 12 years ago

@weiqiyiji We've had some problems with other IDO implementations, especially concerning large sets of options (e.g. textmate-goto-file on large repositories) and with cabbage stuff using completeing-read as not expected by IDO - I don't remember the details though. Thats why I would like that those things are tested before merging, as it should be done with all pull requests. The problem though is that I'm not able to do it myself since I'm not at home this month. But I know that @phgross uses the affected parts of cabbage ;) Other than that I've no objections at all and am looking forward to a better completeing experience :)

senny commented 12 years ago

I'm using this PR for some time now. Most things work exceptionally good. I had some troubles with ucs-insert. This opened a completion for every unicode character which got my Emacs instance into "beach ball of death"-mode (OSX)

senny commented 11 years ago

I'm working with this branch for quite some time now and never had a problem except with ucs-insert. @weiqiyiji can you check out if it is possible to disable ido-ubiquitous just for that function? If its possible please update the PR.

@jone I wait with the merge until you had the chance to try the branch out for yourself. I think its a very good addition and we should get this in core asap when you are back.

weiqiyiji commented 11 years ago

@senny ok, I'll try

senny commented 11 years ago

@jone can you give this one a go?

jone commented 11 years ago

Yes, I think :) I'm merging it.