senny / cabbage

get the maximum out of emacs
http://senny.github.com/cabbage/
156 stars 21 forks source link

New version of emacs-eclim & completion setup stuff #173

Closed fred-o closed 1 year ago

fred-o commented 11 years ago

Hi, I've reworked the completion code in emacs-eclim, and correspondingly updated the version in cabbage.

Also, an older change which fixed indenting of certain methods in java code seems to have snuck in as well.

senny commented 11 years ago

Could you rebase the branch, to remove your local merge commits?

Thanks very much for the work! :heart:

fred-o commented 11 years ago

Rebased!

senny commented 11 years ago

@jone noticed that this change executes code for all installs that have the completion bundle enabled. I'm not sure if we should set cabbage-java-use-eclim to nil and then set it to t in the bundles, that actually make use of eclim. This would mean, that if I don't have the java-bundle (or other bundles using eclim) enabled, it won't enable eclim within the completion bundle.

@fred-o what do you think?

jone commented 11 years ago

If the eclim sources have a decent fallback we could also use separate completion frameworks (e.g. auto-complete-eclim and company-mode-eclim).

fred-o commented 11 years ago

Sorry I forgot to follow up on this. I guess we could make nil the default for cabbage-java-use-eclim, but I suspect it could be tricky to enable it automatically in other bundles as we would be very dependent on the order the bundles are loaded. Better then to have the user enable eclim exlicitly.

senny commented 11 years ago

@fred-o could we detect of a working eclim installation is present? If so we can set the variable to t if an installation exists and use nil otherwise.

senny commented 11 years ago

sorry, hit the wrong button :neckbeard:

fred-o commented 11 years ago

@senny I think it'd be tricky to detect the installation correctly.

senny commented 11 years ago

/cc @jone

so I think we need to find a solution to make it nil by default and enable it from the bundles. I think (defvar) for the default and (setq) to override should work.