Update Popwin package and setup

senny / cabbage

get the maximum out of emacs

http://senny.github.com/cabbage/

156 stars 21 forks source link

Update Popwin package and setup #193

Closed tonini closed 11 years ago

tonini commented 11 years ago

Update of the popwin.el package.
Define another popwin:popup-window-height, default of 15 is to low. (for example for rgrep and compilation buffer)
Set special-display-function variable to popwin:display-buffer. Reason:

popwin:display-buffer displays special buffers in a popup window and displays normal buffers as unsual. Special buffers are specified in popwin:special-display-config, which tells popwin how to display such buffers. See docstring of popwin:special-display-config for more information.

tonini commented 11 years ago

/cc @senny @jone

senny commented 11 years ago

I'll try to test this one out. It will take some time though.

tonini commented 11 years ago

:+1:

senny commented 11 years ago

After using this PR for a few days I start to remember why I don't like popwin. I don't like that windows like *grep* just disappear. I like to treat them like a normal buffer because I want to jump back and forth. It feels odd to use this configuration and my workflow feels more tailored to the default Emacs behavior.

@jone I'd be interested to get your opinion on that subject

tonini commented 11 years ago

I see your point. popwin is in that cause configurable, so it's easy to disable it for custom buffers. But after thinking about it why I like it, it's just about that the compilation buffer, which we use for running tests, are always at the same place and that's something I like very well in my workflow.

Maybe there is another way to implement this feature. What do you think about that? And the end we don't use popwin at all in the cabbage core.

senny commented 11 years ago

I think popwin is still a dependency of something we depend on (maybe auto-complete?). I'd love to see a way to make the compilation buffer appear at the same place all the time.

If popwin actually is a dependency and we can't completely remove it, a solution would be to strip it down completely and just use it for *compilation*.

tonini commented 11 years ago

I will check out the dependency and also for a solution to setup popwin just for the *compilation* buffer.

Thanks for the feedback. :swimmer:

tonini commented 11 years ago

As I can see in the auto-complete package, there is just a dependency on popup not popwin.

So we could remove it completely or setup popwin to just work with the *compilation buffer. Actually I think it's kind of a heavy move to just depend on popwin just for this kind of feature, maybe we could write something by ourselves.

senny commented 11 years ago

@tonini I'm leaning toward removing popwin and dealing with *compilation* ourselves.

tonini commented 11 years ago

@senny I agree with that.

Should I update the PR for remove it?

senny commented 11 years ago

@tonini :+1:

tonini commented 11 years ago

@senny Could you please check if I missed something? Thanks :)