Closed tonini closed 11 years ago
/cc @senny @jone
I'll try to test this one out. It will take some time though.
:+1:
After using this PR for a few days I start to remember why I don't like popwin. I don't like that windows like *grep*
just disappear. I like to treat them like a normal buffer because I want to jump back and forth. It feels odd to use this configuration and my workflow feels more tailored to the default Emacs behavior.
@jone I'd be interested to get your opinion on that subject
I see your point. popwin
is in that cause configurable, so it's easy to disable it for custom buffers. But after thinking about it why I like it, it's just about that the compilation
buffer, which we use for running tests, are always at the same place and that's something I like very well in my workflow.
Maybe there is another way to implement this feature. What do you think about that? And the end we don't use popwin
at all in the cabbage core.
I think popwin is still a dependency of something we depend on (maybe auto-complete
?). I'd love to see a way to make the compilation buffer appear at the same place all the time.
If popwin actually is a dependency and we can't completely remove it, a solution would be to strip it down completely and just use it for *compilation*
.
I will check out the dependency and also for a solution to setup popwin
just for the *compilation*
buffer.
Thanks for the feedback. :swimmer:
As I can see in the auto-complete
package, there is just a dependency on popup
not popwin
.
So we could remove it completely or setup popwin
to just work with the *compilation
buffer. Actually I think it's kind of a heavy move to just depend on popwin
just for this kind of feature, maybe we could write something by ourselves.
@tonini I'm leaning toward removing popwin and dealing with *compilation*
ourselves.
@senny I agree with that.
Should I update the PR for remove it?
@tonini :+1:
@senny Could you please check if I missed something? Thanks :)
popwin.el
package.popwin:popup-window-height
, default of15
is to low. (for example forrgrep
andcompilation
buffer)Set
special-display-function
variable topopwin:display-buffer
. Reason: