update magit to the latest version

[tonini]

Hi,

I stumbled over an issue with magit and the actuall emacs HEAD version:

https://gist.github.com/tonini/6162073

This is fixed in the current magit version, so I did an update.

@senny Could you make a test run with your current emacs version before merging? :yum:

[senny]

I don't use magit often, @jone can you verify that your workflow still works after the update?

[tonini]

@senny I think the reason @jone is not answering is that he is using vim now :) Oh wait, he came from vim right? ;)

[senny]

I'm pretty sure he is not :smiling_imp:

[tonini]

Why? Sounds he sitting next to you. :grin:

[jone]

It seems that it does not work with 24.2, I get

file-error "Cannot open load file" "cl-lib"

Here is the full traceback, here is a similar issue.

I assume that it will probably just work with 24.3. I'm not sure about setting 24.3 as minimum requirement.

How do we address this?

[tonini]

I'm think there is definitely no point to set a Emacs 24.3 version as minimum requirement.

Here is also an issue about this case.

What if we integrate cl-lib into cabbage? Sure, there would be a dependency more, but also brings a support for Emacs Versions under 24.3.

[jone]

@tonini thought about the same. I've locally integrated cl-lib 0.2 as vendor and loaded it in the git bundle, seems to work fine. Can you test the same and update the pull-request?

[tonini]

@jone could you please run a test with this setup?

If everything is ok, you're free for a merge. :stuck_out_tongue_winking_eye:

[jone]

:+1: Works on my 24.2, @senny does it work for you too? Any objections about including cl-lib?

[senny]

It does work on my 24.3 installation on my Notebook. :ship: :it:

[senny]

thanks guys! :yellow_heart:

[jone]

yay :sparkles:

[tonini]

hurray :sunflower: