Closed tonini closed 11 years ago
I don't use magit often, @jone can you verify that your workflow still works after the update?
@senny I think the reason @jone is not answering is that he is using vim now :) Oh wait, he came from vim right? ;)
I'm pretty sure he is not :smiling_imp:
Why? Sounds he sitting next to you. :grin:
It seems that it does not work with 24.2, I get
file-error "Cannot open load file" "cl-lib"
Here is the full traceback, here is a similar issue.
I assume that it will probably just work with 24.3. I'm not sure about setting 24.3 as minimum requirement.
How do we address this?
I'm think there is definitely no point to set a Emacs 24.3 version as minimum requirement.
Here is also an issue about this case.
What if we integrate cl-lib
into cabbage? Sure, there would be a dependency more, but also brings a support for Emacs Versions under 24.3
.
@tonini thought about the same. I've locally integrated cl-lib 0.2 as vendor and loaded it in the git bundle, seems to work fine. Can you test the same and update the pull-request?
@jone could you please run a test with this setup?
If everything is ok, you're free for a merge. :stuck_out_tongue_winking_eye:
:+1: Works on my 24.2, @senny does it work for you too? Any objections about including cl-lib?
It does work on my 24.3
installation on my Notebook. :ship: :it:
thanks guys! :yellow_heart:
yay :sparkles:
hurray :sunflower:
Hi,
I stumbled over an issue with
magit
and the actuallemacs HEAD
version:https://gist.github.com/tonini/6162073
This is fixed in the current
magit
version, so I did an update.@senny Could you make a test run with your current
emacs
version before merging? :yum: