search

senny / cabbage

get the maximum out of emacs
http://senny.github.com/cabbage/
156 stars 21 forks source link

rinari repository not up to date with rails #198

Open tonini opened 10 years ago

tonini commented 10 years ago

Hi,

rinari isn't actually working well with rails 3/4 and one of the reasons might be that there're no updates for the last 5 years.

the rinari fork https://github.com/eschulte/rinari is well maintained by @purcell, maybe we consider to use that source instead?

@senny whats your opinion on that?

senny commented 10 years ago

We should either drop it, or update it. However there is an important caveat: Rinari bundles some tools used in the ruby-bundle. I'm not sure what the current situation is and if we are overwriting these libraries or are actually using them.

purcell commented 10 years ago

@senny Rinari doesn't bundle ruby-mode or inf-ruby any more: ruby-compilation.el and jump.el are in the same github repo, but they (and rinari) are made available as 3 separate packages.

senny commented 10 years ago

oh, that is great news! I've given up on Rinari some time ago but I think it's a good time to revisit this decision.

@tonini are you interested in working on a PR with an updated version of Rinari? I'm willing to work with it for some time to see how it fits into cabbage.

@purcell do you happen to know if Rinari works with Enhanced-Ruby-Mode?

tonini commented 10 years ago

@senny Great! sure I will make a PR with the updated version.

purcell commented 10 years ago

@senny Yes, I think so. We have at least one chunk of code (syntax-highlighting of Rails keywords) which explicitly supports both ruby-mode and enhanced-ruby-mode.

senny commented 10 years ago

@purcell great. I'm gonna try those in combination. Thank you for jumping in and sharing your insight :yellow_heart: .

tonini commented 10 years ago

@senny the branch is ready for testing.

You have to git submodule sync before doing a scripts/update.sh, but I think you know that already. ;)