search

senny / cabbage

get the maximum out of emacs
http://senny.github.com/cabbage/
156 stars 21 forks source link

the global key setup for `recentf-ido-find-file' function is not proper set #204

Closed tonini closed 10 years ago

tonini commented 10 years ago

Thanks for the feedback of @lephyrus, we realized that the recentf-ido-find-file function isn't set correctly to a global key in the ergonomic bundle.

Move the setup for the key into the project function key section would fix it.

senny commented 10 years ago

I don't see why moving it into another section fixes the issue. Your diff removes fboundp, which is to make sure that it's not bound for Emacsen where the function does not exist. (I can't remember if that was due to different Emacs versions or whatever reason). My guess is, when the bindings are loaded the function was not yet required so the key will not be bound. We need to fix that issue and investigate why there was an fboundp call in the first place.

tonini commented 10 years ago

Ah ok, I see the point.

tonini commented 10 years ago

@senny I'm a bit confused with the statement:

which is to make sure that it's not bound for Emacsen where the function does not exist. (I can't remember if that was due to different Emacs versions or whatever reason).

But the recentf-ido-find-file is defined via the project bundle: https://github.com/senny/cabbage/blob/c197f3357a1c9613864307ed8304e4a255d4e260/bundles/project/bundle.el

So in that case it's would be always available, right?

Please enlighten me. :)

senny commented 10 years ago

haha I didn't remember at all why the fboundp was there. It just strikes me as necessary to investigate why it's there before dropping it.

I had no clue we were bundling that function so I don't see a reason to keep the fboundp. It's probably just legacy code.

Thanks for your time.