Closed tonini closed 9 years ago
Wouldn't this PR make lib/themes
obsolete? If so, why not remove it?
@senny you're right. I made the update
I'm generally OK with this PR, sad thing is that after the update everyone will loose their themes (because theme-roller
bundle won't be loaded). Can you think of a less painful upgrade path?
@senny I think this is not that easy to achieve. In this situation the user is actually required to update his config.el
.
What we could do it add a message to the install.sh
and update.sh
scripts about this change.
What about using cabbage-load-bundle
to load theme-roller
if it hasn't been loaded by the users config.el
. If this branch is triggered, we can output a deprecation warning that this will no longer be the case in future releases and that one needs to add theme-roller
to the config.el
. Adding it would obviously get rid of that message. Also if there is a way to tell wether the user is using a deftheme
, we can skip that loading / message stuff as well.
Ok, the theme-roller
will be loaded if not already, and a deprecated warning will be shown.
There is actually no way to find out if already a theme is used created by the deftheme
macro.
@senny you're right. The warn
function is a much better choice because its shown in a separate buffer. I made the change
Maybe you can find something about the use of deftheme
using the custom-enabled-themes
variable. It appears as it would have an entry when you are using load-theme
or enable-theme
. I can't say for sure though.
I think you're right. The custom-enabled-themes
variable will be updated with the theme you loaded via load-theme
.
Let me update the code
@senny OK I made the update.
@tonini added a few more comments. Sorry for all the nitpicks. Working on rails made me more sensible to a clear and compatible upgrade path :blush:
@senny no worries mate. :-) I like that kind of nitpicks. :-) I'm always willing to learn :+1:
check the update :)
@senny thanks, great summary of how to make deprecated message :+1:
check the update...;-)
@tonini thanks for your work and endurance :yellow_heart:
Check out the merge commit (https://github.com/senny/cabbage/commit/8a6bcc6dc73e321652ee8ebe4aea4dd25ff48740) I rephrased the message a little bit and simplified the (and
slightly.
@senny great! :) thanks for letting me contribute. ;-)
@senny because of the improvements of the
deftheme
macro in emacs 24, I think there should be the possibility to choose between theme-roller or themes served viadeftheme
. There are already a lot of nice themes out there.What do you think?