search

senny / cabbage

get the maximum out of emacs
http://senny.github.com/cabbage/
155 stars 21 forks source link

Transition to Flycheck #220

Open tonini opened 10 years ago

tonini commented 10 years ago

I always just had problems with flymake and most of the time just haven't it enabled.

I think we should consider to switch to Flycheck.

Why?

Because it's just great. Language support is amazing, it's highly maintained and people just use it.

@senny @jone what do you guys think about that?

senny commented 10 years ago

can you prepare a PR for me to check out for a bit? I'm not a big fan of Flymake but it serves the purpose I use it for "ok". If Flycheck delivers the same I'm happy to move over.

jone commented 10 years ago

I've had trouble with flymake and compile-mode; flymake crashes sometimes silently while compiling. If flycheck does the job and does not crash I'll happily switch :wink:

phgross commented 10 years ago

I've had the same problems like @jone describe. So if flycheck would solve this troubles, that would be nice :+1:

tonini commented 10 years ago

@jone What's the default source code checker for python these days? Currently we're going with pyflakes and flymake. Maybe going with flake8 https://pypi.python.org/pypi/flake8 would be decent way.

What do you think?

jone commented 10 years ago

I'd go with pyflakes only.

flake8 includes pyflakes but also pep8. pyflakes only checks for logical errors in the code, but pep8 also checks for the python style guide, which results in a lot more errors. Although we (at my company) try to apply pep8 to a certain degree it is sometimes impossible and often hard to do so.

Personally I want see pyflakes while coding (as flymake does it with a red background) but I want pep8 errors only on demand (I have other setups for this). I think I would disable it if it would include pep8 because of the code I sometimes work on and because it would be too distracting for me..

tonini commented 10 years ago

@jone So you think we should just setup flycheck with pyflakes and let the rest to the user itself to customize?

jone commented 10 years ago

Yes, that sounds good :+1: