search

senny / cabbage

get the maximum out of emacs
http://senny.github.com/cabbage/
156 stars 21 forks source link

decrease-font-size: Symbol's function definition is void: restore-frame #84

Closed fred-o closed 12 years ago

fred-o commented 12 years ago

When I call increase-font-size or decrease-font-size I get the following error message:

decrease-font-size: Symbol's function definition is void: restore-frame

However, things seem to work fine. I'm running emacs 23.3.1 on Ubuntu 11.10.

senny commented 12 years ago

I guess the restore-frame function is used to re-maximize Emacs so that you can see everything when you are in full-screen mode. I'll look into it and add the missing dependency if it is required.

@jone do you know more about that?

jone commented 12 years ago

restore-frame is a maxframe function, but maxframe was not loaded in accesibility bundle but in maximize bundle. I've added the missing e-max-vendor..

@fred-o: could you update e-max (run scripts/update.sh) and try again?

fred-o commented 12 years ago

Yup, works like a charm.

However, increase-font-size behaves a bit strange. When called, it maximizes the window, and also changes the font size of the status bar and minibuffer (which decrease-font-sizedoesn't do).

jone commented 12 years ago

I've updated maxframe and made increase-font-size and decrease-font-size only resize the frame if the maximize bundle is active. This should fix the unwanted maximizing of the frame.

The minibuffer size is still wrong when in fullscreen mode, but since fullscreen is in C (and - at least on Mac OS - introduced with a Emacs patch) it is hard to detect it..

@fred-o does that fix your issues?

senny commented 12 years ago

This seems to be done. I'll close it for now. Reopen if there are any further problems.