search

senny / emacs-eclim

This project brings some of the great eclipse features to emacs developers. It is based on the eclim project, which provides eclipse features for vim.
http://www.emacswiki.org/emacs/EmacsEclim
587 stars 102 forks source link

Some goodies / fixes I found after a few weeks of use. #238

Open ovy opened 9 years ago

ovy commented 9 years ago

The last [non-merge] commit might be the most interesting to you. Please pick what you want. In order of importance:

https://github.com/ovy/emacs-eclim/commit/f684c86046e5576f8172ceff8737cc190517e47a https://github.com/ovy/emacs-eclim/commit/6c577593eeb396479ff7db9662cca8efdff00d82 https://github.com/ovy/emacs-eclim/commit/33c0ef4d5272f15ed0524cbd950bac1bac773051

The others are use-case-y.

kleewho commented 9 years ago

Thanks. Some things will definitely be helpful, but I need some time to digest them. Could you elaborate a little about the different use cases/issues for each of the commits?

ovy commented 9 years ago

I've added some comments to the commits (if you click through), except a couple that were self-explanatory.

I'm not as fond of the compilation buffer as I was when I started, so you can discard that if you want. On the other hand, it does fix some broken-ness and it doesn't touch anything else, so why not.

kleewho commented 9 years ago

@ovy thank you for all hard work. Can you not push any new commits to this PR and create new ones instead. It will be easier to handle.

kleewho commented 9 years ago

@jchochli could you help me with this somehow? There's plenty of commits. We can split them or something

ovy commented 9 years ago

@kleewho Thanks for looking!

The problem with making little feature branches (which I do in other situations) is that I only really run with one Emacs state and my session is very long-lived. So other branches would contain commit states that I've never actually run as published, and it would be real easy for a bug (e.g. dependency) to sneak in.

So what I'll do is I'll stop pushing to this PR, but wait until you tell me which commits you want to keep, back out the rest and make sure it all works, then put further changes on top of that state. It's a little hard to do this for very long, though :)

Best, Ovy

P.S: sent this much earlier, but flaky wifi stops github rather unnoticeably. I'm watching this with interest, rest assured :)

vspinu commented 9 years ago

Would it be possible to merge this and other pulls soon? I I would like to contribute some stuff but having all these outstanding PR's makes it difficult to judge what is there and what is not.