search

senny / pdfjs_viewer-rails

PDF.js viewer packaged as a Rails engine.
MIT License
114 stars 175 forks source link

Upgrade to pdf.js 1.5.188 #24

Closed jheth closed 7 years ago

jheth commented 8 years ago

I wanted to get this up to date with the latest stable pdf.js.

This is loading and working for me but I am not entirely about the introduction of pdf.worker.js. I set the workerSrc which was previously commented out.

@senny Do you see issues with upgrading?

senny commented 8 years ago

pdf.worker.js is not particularly new. I've always used the combined js file.

senny commented 8 years ago

There have been code edits in the existing files. If you update you must make sure that these edits are persisted. /cc @siegy22

jheth commented 8 years ago

@senny Is this something you want to do? Is there more I can do?

senny commented 8 years ago

@jheth yes, generally we used to upgrade the PDF.js versions here and then. The difficult part is that the distributed files have been modified in this project. The only way to find out what modifications that are is by looking at the git history. I do vaguely remember something about rendering links.

Given the patches made in this project are applied to the newest version it's ok to upgrade PDF.js.

Unfortunately I am no longer working on projects that make use of this gem. @siegy22 should still be on that and will hopefully get back to you.

siegy22 commented 7 years ago

I am very sorry for the extrem long delay, I hadn't this much time and was on vacation the last 2 weeks. Going to look over this tomorrow or this weekend!

OlivierGrimard commented 7 years ago

+ 1

siegy22 commented 7 years ago

Gonna close this, is replaced by #34