Update pdf.js to v1.9.426

senny / pdfjs_viewer-rails

PDF.js viewer packaged as a Rails engine.

MIT License

114 stars 174 forks source link

Update pdf.js to v1.9.426 #46

Closed gabrieldeal closed 5 years ago

gabrieldeal commented 6 years ago

Updating pdf.js to v1.9.426. And updating the documentation in UPDATE.md.

I noticed #45 after I did this work. Feel free to close this PR as a duplicate. I did put all my manual edits into separate commits, so it should be pretty easy to see the changes I made to the original pdf.js files.

Note: one of the tests fails for me on this branch, but it also fails in the same way in an unmodified branch. We'll see how it runs on Travis CI.

gabrieldeal commented 6 years ago

I did not realize what I was getting into when I started this. :)

The tests pass for more recent versions of Rails and Ruby. But they fail for Rails 5.0 and older and for Ruby 2.2.

For what it is worth:

Ruby 2.2 has been EOLed: https://www.ruby-lang.org/en/downloads/branches/
Rails 5.1 and older are still getting patched for security bugs (but not normal bugs): https://guides.rubyonrails.org/maintenance_policy.html

jone commented 5 years ago

pdfjs_viewer-rails = 0.3.0 is out, updating PDF.js to 1.10.100 (see #51) and making this PR obsolte. Thanks anyway 😉