senny / pdfjs_viewer-rails

PDF.js viewer packaged as a Rails engine.
MIT License
114 stars 175 forks source link

Avoid Rails autoloading issues by inherit directly #48

Closed tobidelius closed 1 year ago

tobidelius commented 5 years ago

We had an issue with rails lazy loading in development. We fetch the pdf on an internal path and "our" ApplicationController took precedence over yours. We fixed this by inheriting directly with the module itself.

evolve2k commented 2 years ago

@sandelius is this still useful ? #cleaningup

tobidelius commented 1 year ago

Probably not since Rails uses another autoloader now.