search

senny / pdfjs_viewer-rails

PDF.js viewer packaged as a Rails engine.
MIT License
114 stars 175 forks source link

Sass deprecated soon #50

Closed xinlangzi closed 4 years ago

xinlangzi commented 5 years ago

This gem has dependency sass_rails which use sass too. Ruby Sass is deprecated and will be unmaintained as of 26 March 2019. Will you update dependency to use sassc_rails? Thank you.

http://sass.logdown.com/posts/7081811

xinlangzi commented 4 years ago

@senny @jone

Do you have any plan to upgrade to sassc_rails?

jone commented 4 years ago

@xinlangzi thanks for pointing out. @siegy22 will take care of it. He us offline until next year though.

aguynamedben commented 4 years ago

Any update on this? I'm upgrading to Rails 6. Rails 6 moves off sass-rails by specifying this version of it:

gem "sass-rails", ">= 6"

That version of sass-rails is really just a wrapper for sassc-rails (link).

simonc commented 4 years ago

Hi! Same issue here, upgrading to Rails 6 and I got stuck when updating sass-rails.

matt-doeringtech commented 4 years ago

Hi all. Love to get this fixed. Sort of stuck otherwise

senny commented 4 years ago

Hi! I've put up a patch to make this transition happen (#67). I'm not using this gem anymore, so any assistance to help test would be very much welcome. It would be great if someone could run their project with based on the branch in the PR and report back if everything behaves as it should.