search

senny / pdfjs_viewer-rails

PDF.js viewer packaged as a Rails engine.
MIT License
114 stars 174 forks source link

Add a cache defeating per version query string to the pdf.worker.js #54

Closed Rotonen closed 5 years ago

Rotonen commented 5 years ago

Users whom have previously accessed the viewer can end up using a cached old worker implementation. Adding a query string forces them to guaranteedly always get the correct one.

Rotonen commented 5 years ago

I dropped testing against the combination of Ruby 2.3 and Rails 4.2 as that combination is troublesome and I could not figure out how to use conditionals for downgrading bundler for that build only.

Downgrading bundler breaks newer rubies.

I find the effort tradeoff reasonable.