Upgrade pdfjs to 2.2.228

senny / pdfjs_viewer-rails

PDF.js viewer packaged as a Rails engine.

MIT License

114 stars 175 forks source link

Closed gingermusketeer closed 2 years ago

gingermusketeer commented 4 years ago

Current version is 1.X

siegy22 commented 4 years ago

Thank you for your contribution, did you take a look at the update guide? We need to apply patches after upgrading.

gingermusketeer commented 4 years ago

@siegy22 yes I did. I applied the patches with adaptations for the new version.

I am using this in production since this was opened and it is working well. Might not work for all cases though.

siegy22 commented 4 years ago

Can you re-add the line I marked? I'll then update the update instructions to include this too. Then this PR should be ready!

siegy22 commented 4 years ago

Last thing to do is probably rebase onto the current master so the tests should pass again.

Alfeezy commented 3 years ago

Bumping this thread- has anybody reviewed the failing check? Seems to have to do with a js error, but it's not visible from the build logs.