senny / pdfjs_viewer-rails

PDF.js viewer packaged as a Rails engine.
MIT License
114 stars 174 forks source link

Remove sass dependency #77

Open mdh opened 2 years ago

mdh commented 2 years ago

pdfjs_viewer-rails depends on sassc-rails, which hasnt been updated in 3 years. See https://github.com/sass/sassc-rails

sassc-rails in turn depends on sassc which is deprecated, see https://github.com/sass/sassc#sassc :

Warning: LibSass and SassC are deprecated. While it will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features. Projects that still use it should move onto Dart Sass.

As there is very little css in this gem, why not get rid of dependency and just use plain css and allow people to use current sass implementations?