senny / rvm.el

use rvm to manage ruby versions within emacs
214 stars 42 forks source link

Ruby version support #35

Closed diasjorge closed 11 years ago

diasjorge commented 11 years ago

So this is my attempt to add support for the .ruby-version and .ruby-gemset files

I didn't write any tests for this since I'm not very sure how the rvm-get-stubs thing works, but I would gladly add them if needed

All the tests run fine btw.

Closes #30 Closes #34

diasjorge commented 11 years ago

I've added support for reading the info from the Gemfile. Support for issues

30 #34

senny commented 11 years ago

this is fantastic. Thanks for this amazing work! :sparkles: :heart: :sparkles:

senny commented 11 years ago

Did you notice that the Travis-CI build failed: https://travis-ci.org/senny/rvm.el/builds/7266740 ?

It passed before: https://travis-ci.org/senny/rvm.el/builds

senny commented 11 years ago

@diasjorge great! If you squash the three fix commits into the original 4 feature commits I'll merge.

diasjorge commented 11 years ago

:ok_hand:

senny commented 11 years ago

@diasjorge awesome! :yellow_heart: :green_heart: :heart: :purple_heart: :blue_heart: