Support all Gemfile ruby-version forms

senny / rvm.el

use rvm to manage ruby versions within emacs

214 stars 42 forks source link

Closed jrep closed 10 years ago

jrep commented 10 years ago

This pull request fixes issue #43:

When ruby-version is taken from Gemfile, three syntaxes are supported:

#ruby=2.1.0
ruby "2.1.0"
ruby '2.1.0'

Currently, rvm.el only recognizes the comment form. But the directive form(s) mean something to Bundler, and should also be allowed.

rejeep commented 10 years ago

Would be awesome if you could add some tests cases for this!

jrep commented 10 years ago

Tests added. History's a bit muddled, sorry (I didn't expect you to pull without the tests). Code changes, test are there, tests pass.

senny commented 10 years ago

@jrep can you squash your commits?

jrep commented 10 years ago

Incorporated all requests; squashed all commits to one.

senny commented 10 years ago

Looking good. :yellow_heart: