search

senorshaun / homebridge-radiora2

Lutron RadioRA2 plugin for homebridge
MIT License
10 stars 5 forks source link

Made all parameters optional aside from ID. #11

Closed cariacou closed 2 years ago

cariacou commented 2 years ago

Fixes #10

senorshaun commented 2 years ago

I’m fine merging all this if you have tested, I’ll merge and then push to npm. Only question I have is about the fan/light bug? Can you give me some more info

On Dec 12, 2021, at 2:00 PM, cariacou @.***> wrote:

 Fixed a bug where model was required (unfortunate call to toString) Fixed a bug where some Fans were being declared as Lights Made all parameters optional aside from ID (name, etc) Updated the readme accordingly You can view, comment on, or merge this pull request online at:

https://github.com/senorshaun/homebridge-radiora2/pull/11

Commit Summary

6495a14 Made all parameters optional aside from ID. File Changes (11 files) M README.md (7) M index.js (16) M lib/accessories/fan.js (12) M lib/accessories/hvaccontroller.js (6) M lib/accessories/keypadbutton.js (9) M lib/accessories/lightbulb.js (6) M lib/accessories/occupancysensor.js (4) M lib/accessories/statelessswitch.js (6) M lib/accessories/visorcontrolreceiver.js (8) M lib/radiora2.js (4) M package.json (78) Patch Links:

https://github.com/senorshaun/homebridge-radiora2/pull/11.patch https://github.com/senorshaun/homebridge-radiora2/pull/11.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

cariacou commented 2 years ago

I've tested it with fans (only thing I am importing in my setup). I updated package.json, iterating the version number 1.3.3.1. Not sure if this was how it is supposed to be. I am assuming you would be in charge of releasing homebridge-radiora2-1.3.3.tgz ?

senorshaun commented 2 years ago

Oh ok. That’s not actually categorizing as light, that’s just how the unique identifier is created for the device. Good catch though.

On Dec 12, 2021, at 2:36 PM, cariacou @.***> wrote:

 @cariacou commented on this pull request.

In index.js:

             if ((fanConfig.id) && (fanConfig.name)) {
  • var uuid = UUIDGen.generate("light:" + fanConfig.id); fan miscategorized as light here

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.