search

sensational / sassphp

PHP bindings to libsass - fast, native Sass parsing in PHP!
Other
229 stars 39 forks source link

Get/Set precision #11

Closed chrinor2002 closed 9 years ago

chrinor2002 commented 9 years ago

An attempt to add a getter/setter for precision as requested in issue #10.

pilif commented 9 years ago

Very cool. Thank you. However, in the test, do you think it would be possible to test that setting the precision actually does something? I mean by compiling some test sass code. If you're too busy that's fine and I'll see I can do it this weekend

chrinor2002 commented 9 years ago

Good thought, I hadn't thought that far. I was mostly just making sure the get/set was working correctly. The added tests should also now test the actual usage of the new values being set by the setter.

pilif commented 9 years ago

Thanks a lot - looks good and tests pass too.