search

sensational / sassphp

PHP bindings to libsass - fast, native Sass parsing in PHP!
Other
229 stars 39 forks source link

[WIP] Libsass 3.2.0 #12

Closed chrinor2002 closed 9 years ago

chrinor2002 commented 9 years ago

An update to libsass 3.2.0. Currently this is beta, but the initial work has been done to bring the php module up to pay with the library. Once the official release comes out this should be able to be merged.

Warning! this contains the removal of the image_path. This is no longer available in libsass: sass/libsass#489

It is also worth mentioning sass/libsass#940. There is a "breaking" change that was introduced related to memory management. The general quick fix was to add a strdup() call before passing along the source. Without this there was a "pointer being freed was not allocated" error.

chrinor2002 commented 9 years ago

Looks like there is only one test still not passing:

parse_file_parses_file.diff:

003+   blah: "hello 4 world px bloon blah"; }
003-   blah: "hello 4 world px bloo\n blah"; }

scss:

blah: "hello #{2+2} world #{unit(23px)} #{'bloo\n'} blah";

Do we happen to know what sass-spec test that came from?

pilif commented 9 years ago

The test.scss comes from the original author who has since abandoned this. I have then run the same files against ruby sass before pushing it here in order to make sure that we generate the same code as ruby sass or, if we don't that we can be sure it's an issue in libsass itself (which it always was back then - the library was in horrible shape).

Current ruby sass produces the same output as you are seeing, so I would say we can just update the (nonesensical to begin with) test

chrinor2002 commented 9 years ago

Alright, assuming there is no other breaking issues before 3.2.0, we should be good to go once its released.

pilif commented 9 years ago

merging this now in preparation of the final release (which then will just be a submodule update).

Again, thanks a LOT for your contribution