search

sensational / sassphp

PHP bindings to libsass - fast, native Sass parsing in PHP!
Other
230 stars 40 forks source link

get/setIndent() does not exists on PHP 8.x #42

Open Sweetchuck opened 3 years ago

Sweetchuck commented 3 years ago

The sass PHP extension can be compiled from source with PHP 8.x (8.0.10), but the \Sass::getIndent() and \Sass::setIndent() methods aren't exist.

Maybe this one is the relevant output:

src/ast_values.cpp: In member function ‘virtual size_t Sass::Number::hash() const’:
src/ast_values.cpp:431:23: warning: loop variable ‘numerator’ creates a copy from type ‘const std::__cxx11::basic_string<char>’ [-Wrange-loop-construct]
  431 |       for (const auto numerator : numerators)
      |                       ^~~~~~~~~
src/ast_values.cpp:431:23: note: use reference type to prevent copying
  431 |       for (const auto numerator : numerators)
      |                       ^~~~~~~~~
      |                       &
src/ast_values.cpp:433:23: warning: loop variable ‘denominator’ creates a copy from type ‘const std::__cxx11::basic_string<char>’ [-Wrange-loop-construct]
  433 |       for (const auto denominator : denominators)
      |                       ^~~~~~~~~~~
src/ast_values.cpp:433:23: note: use reference type to prevent copying
  433 |       for (const auto denominator : denominators)

PHP 7.x (7.4 and 7.3) works fine. LIBSASS_VERSION="3.6.1"