Inconsistent method naming

sensational / sassphp

PHP bindings to libsass - fast, native Sass parsing in PHP!

Other

229 stars 39 forks source link

Inconsistent method naming #6

Closed ikhsan017 closed 9 years ago

ikhsan017 commented 9 years ago

Hi there,

just a suggestion for method naming, why there is a mix of camel case style and underscore style of method naming? such as setIncludePath and compile_file?

IMHO, would it be better to rename the compile_file to `compileFile``

regards Ikhsan

pilif commented 9 years ago

Yeah. You're right. The old name came from the original implementation I forked from.

I'll have a look into making an alias.