search

sensaura-public / iotweb

A simple HTTP and WebSocket server component for Windows 10 IoT Core and .NET 4.5
38 stars 21 forks source link

small change needed to get it working with Edge #1

Closed ossandust closed 8 years ago

ossandust commented 8 years ago

First of all thanks for this very interesting project ! Currently the UWP projects don't compile - probably work in progress - the fixes are obvious (move the port specification from Start() to ctor and a few other minor changes to comply to the IServer interface. More importantly, I noticed that web sockets don't work from Edge. Apparently the check on the header values in UpgradeToWebsocket() must be made case insensitive - the Edge browser sends a header "Upgrade:Websocket" which doesn't get recognized. See the official spec at https://tools.ietf.org/html/rfc6455#section-4.2.1 > section 4.2.1.3 & 4.2.1.4 Thanks!

sensaura-public commented 8 years ago

Thanks, I've queued it for the next release. The 0.8.x branch is more stable (that is the code that is used to generate the NuGet package). The master branch may or may not work at any given time.

sensaura-public commented 8 years ago

Fixed in branches 0.8.x and master - will be rolled into next NuGet version.