search

sense-of-security / ADRecon

ADRecon is a tool which gathers information about the Active Directory and generates a report which can provide a holistic picture of the current state of the target AD environment.
https://senseofsecurity.com.au/
GNU Affero General Public License v3.0
1.64k stars 277 forks source link

Total user accounts #10

Closed apperrault closed 5 years ago

apperrault commented 5 years ago

First, great software. It has been a lifesaver for me and my company. The 3 times I have run it, when I go to the User Stats, the code says =CountA(Users!A301:A301)-1. and I always end up with a total of 0 in Red, and the percentages are always throwing a divide by zero error. is that correct?

thanks

prashant3535 commented 5 years ago

HI,

Could you please provide additional information about how ADRecon was executed (using RSAT/LDAP) and the version of MS Office? Are there any blank fields in the Enabled column in the users sheet?

In the sample output, the formula calculated is =COUNTA(Users!A:A)-1 by the following line: https://github.com/sense-of-security/ADRecon/blob/master/ADRecon.ps1#L3215

apperrault commented 5 years ago

I am running this using RSAT simply running adrecon.ps1. I am running with from a Windows 10 system, with the RSAT tools installed, using Domain Admin rights. I don't see any empty columns in my users csv or in the excel document

apperrault commented 5 years ago

Also, if i change the formula to =COUNTA(Users!A:A) -1 it works just fine

prashant3535 commented 5 years ago

Hi,

Could you please confirm if this commit resolves the issue for you ?

apperrault commented 5 years ago

I just did a git pull and will re-run it and let you know how it goes

apperrault commented 5 years ago

that worked. thanks