Confirmation Link Encoding

[felixerdy]

When using an email address with suffix, e.g. hello+opensensemap@example.com, the + sign is not encoded correctly.

Expected Behavior

+ gets encoded to %2B

https://opensensemap.org/account/confirm-email?email=hello%2Bopensensemap@example.com&token=xxx

Current Behavior

+ gets encoded to (space)

https://opensensemap.org/account/confirm-email?email=hello opensensemap@example.com&token=xxx

Possible Solution

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Context

A customer notified us about this issue

Your Environment

• Version used:
• Environment name and version (e.g. Node v8.3.0):
• Server type and version:
• Operating System and version:
• Link to your project:

[mpfeil]

This should be an issue within our mailer

[mpfeil]

@felixerdy I have fixed this in our mailer and deployed it to https://testing.opensensemap.org

Could you verify that it´s encoded correctly?

[felixerdy]

Just tested. Seems to be working 🎉 Thank you!

closed in https://github.com/openSenseMap/mailer/pull/77

[mpfeil]

Going to create a new version of the mailer and will deploy it tomorrow