fix filtering (in)active senseboxes

sensebox / openSenseMap

Platform for storing and exploring sensor data

https://opensensemap.org

MIT License

99 stars 51 forks source link

fix filtering (in)active senseboxes #87

Closed noerw closed 8 years ago

noerw commented 8 years ago

currently there are 3 classes of senseboxes, but only 2 marker styles:

"active" (green marker, data newer than 30 days)
"inactive" (grey marker, data older than 30 days)
"dead" (grey marker, data older than 365 days)

there are 3 issues with the active marker filtering:

[x] 3 classes should be displayed as 3 icons
[x] disabling the "show all" checkbox in the UI should also hide the dead markers (at least a clarification is needed)
[x] the code doing the filtering could be simplified or at least be well commented

christophfriedrich commented 8 years ago

Sidenote: I think 30 days is a rather optimistic threshold to declare a sensebox "active" -- in my opinion something like 7 days would be a better fit as failing to transmit data for an entire week sounds quite "inactive" to me.

ubergesundheit commented 8 years ago

Ping @robarto @mpfeil This is my proposal for colors: Green as it was before, Dark Green and Grey for the 30 and 365 day thresholds. osem_markers_inactive_colors

I also think 30 and a year is really rather optimistic. 7 days and 30 days suggested by @christophfriedrich seems better

mpfeil commented 8 years ago

Go with 7 days and 30 days

robarto commented 8 years ago

Am Donnerstag, 2. Juni 2016 schrieb Matthias Pfeil :

Go with 7 days and 30 days

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sensebox/OpenSenseMap/issues/87#issuecomment-223291896, or mute the thread https://github.com/notifications/unsubscribe/ADz7O4vO8Kqjbhjgvwlbp8xVKftDASvSks5qHtsmgaJpZM4ImUMK .

Thomas Bartoschek ifgi - Institute for Geoinformatics University of Münster Heisenbergstr. 2 48149 Münster, Germany

Phone: +49 (0)251 83 30011 Mobile: +49 (0)173 511 6094 Fax: +49 (0)251 83 39763

Email: bartoschek@uni-muenster.de http://ifgi.uni-muenster.de/ http://www.gi-at-school.de/ http://vespucci.org/

ubergesundheit commented 8 years ago

The checkbox is now unchecked by default.

mariopesch commented 8 years ago

Can we set a 12hours deadline for the active boxes? ping @mpfeil @robarto @janwirwahn

ubergesundheit commented 8 years ago

fine by me.

Also the checkbox is not unchecked by default after discussing with @janwirwahn

mpfeil commented 8 years ago

@ubergesundheit can we close this issue?

ubergesundheit commented 8 years ago

yeah @mariopesch can create a new issue for 12h