sensebox / ttn-osem-integration

integration for thethingsnetwork.org to opensensemap.org
MIT License
6 stars 3 forks source link

Change way of sensebox/home decoder #16

Closed mpfeil closed 1 year ago

mpfeil commented 5 years ago

sensebox/home profile is now able to handle every sensor setup of a senseBox:home. Its not restricted to the old full sensor setup. If thepayload is longer than the sensorMatching of the correspondig box the unused bytes are ignored.

ToDo

mpfeil commented 5 years ago

This assumes that measurements are submitted in a specific order, correct? Which order? Would be good to document that.

Yes of course. If we merge the PR there will also be a generated LoRa sketch at the end of registration. But afaik the specific order is always relevant. Or did I miss something?

Shouldn't the case of to few bytes still be treated as an error? When measurements are missing this is not the behaviour as configured.. Also we don't know which ones are missing, and this can mess up the data.

Fair point. I will think about it.

How are these warnings handled? afaik there is no mechanism to show them to the user..

Right now there is no mechanism. But there will be later. Just as a preparation for it.

Maybe rebase this onto feature/mqtt, as that's the latest code.. But can be done later as well I guess

We will do it later. We want to release the new LoRa sketch generation and after it release your changes of feature/mqtt

mpfeil commented 1 year ago

Closed. Already included in new main branch