search

sensein / b2aiprep

Apache License 2.0
5 stars 6 forks source link

added fig generation code #17

Closed Rahul-Brito closed 6 months ago

Rahul-Brito commented 6 months ago

added figure generation code. The test figure I was getting looked weird so I need to maybe debug, but submitting PR for now. Code seems good?

satra commented 6 months ago

putting tags back so we can release when this is merged.

satra commented 6 months ago

in addition to the CLI, which needs to take into account a list of files as opposed to file,subject,task, can you check/update the README so that alex's team can use this on their own with the new csv format?

Rahul-Brito commented 6 months ago

@satra i think this should be ready, maybe i could handle the paths in batch_csv_convert() as Path instead of str, and I did not actually run the CLI commands to test

satra commented 6 months ago

since we don't have tests yet, please do run the CLI commands as that's what they would be using.

Rahul-Brito commented 6 months ago

@satra should be ready to merge