search

sensein / b2aiprotocol

http://sensein.group/b2aiprotocol/#
0 stars 1 forks source link

protocol needs some tlc #19

Open satra opened 4 days ago

satra commented 4 days ago

this protocol has a bunch of things that don't seem correct.

  1. [validation issue] for a lot of items the name of the file and id dont match. seems like some autoconversion didn't understand reproschema
  2. for several items, the redcap2rs item seems fine, but was not used here (e.g. confounders)
  3. i added a brief readme, but currently the protocol isn't building because of validation issues.
ibevers commented 3 days ago
  1. The validation passes. I thought that should check file name and ID match. Is that not the case?
ibevers commented 3 days ago
  1. This seems non-critical. Do you agree?
ibevers commented 3 days ago
  1. The validation passes for me, but I'm using reprsochema==0.7.2. I see there is a newer one. I'll try that.
ibevers commented 3 days ago

@satra It passes the latest validation now

satra commented 3 days ago
  1. This seems non-critical. Do you agree?

this makes us diverge between app updates and reproschema. while non-critical, quite inefficient, since we need to be in sync with the app.