sensein / covid19

A survey protocol for covid19
https://sensein.github.io/covid19/
Apache License 2.0
0 stars 7 forks source link

First round of feedback #31

Closed danielmlow closed 3 years ago

danielmlow commented 3 years ago

Urgent:

Less urgent:

In reproschema-library:

danielmlow commented 3 years ago

could you also change the mental health items to regular items here: https://github.com/sensein/covid19/blob/master/activity/MentalHealth/MentalHealth_schema#L32

instead of sub-activities change them to “phq9_1”, “phq9_2", “gad7_1”, etc.

and then delete phq2 activity from that repo

danielmlow commented 3 years ago

@sanuann

  • [x] change the testing question to have an "I'm waiting for test results." option. and skip asking about the test if that option is selected and instead simply ask for test date.

schema: https://github.com/sensein/covid19/blob/master/activity/covid19/covid19_schema

I finished this but it's not working. I added a new option 3 to "I'm waiting for test results.": https://github.com/sensein/covid19/blob/master/activity/covid19/items/covid19_status_tested

If they select 3, then they are asked about the date (I obtained this template from some other activity in the library): https://github.com/sensein/covid19/blob/master/activity/covid19/items/covid19_date_test

I change to schema version to rc2. I'm guessing there's something off in covid19_date_test.

sanuann commented 3 years ago

https://github.com/sensein/covid19/blob/master/activity/covid19/covid19_schema

you haven't added the new item (covid19_date_test) to theorder array!

danielmlow commented 3 years ago

https://github.com/sensein/covid19/blob/master/activity/covid19/covid19_schema

you haven't added the new item (covid19_date_test) to theorder array!

Ah, sorry about that. please add "items/covid19_date_test", in between these two: image

Here: https://github.com/sensein/covid19/blob/3b998111345fdc41ccf78ec865ee284302858a7d/activity/covid19/covid19_schema#L26

satra commented 3 years ago

@sanuann - when i go to the current website, i don't get the export option, but i get the submit option.

the submit option should only appear if the url has the right parameters, while the export option should appear if the submit capability is not there.

satra commented 3 years ago

there is one remaining issue in the list above that needs to be fixed.

danielmlow commented 3 years ago

The output are files like this: 20201222T152938.019017Z0000-1d911c4d-dd82-44ff-bf31-1c94f034be6e-6.zip When you unzip we get a file called responses, but it would be better to get the same name as the zip file for the unzipped file instead.

satra commented 3 years ago

can we do this: responses/<projectname>/sub-<uid>/<data> ?

danielmlow commented 3 years ago

This continues here: https://github.com/sensein/covid19/issues/52