search

sensein / etelemetry-client

Etelemetry client
Other
3 stars 9 forks source link

enh: add version check as a function to etelemetry #13

Closed satra closed 4 years ago

satra commented 4 years ago

@yarikoptic and @mgxd - please take a look.

codecov-io commented 4 years ago

Codecov Report

Merging #13 into master will decrease coverage by 8.47%. The diff coverage is 77.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   94.91%   86.44%   -8.48%     
==========================================
  Files           3        2       -1     
  Lines          59       59              
==========================================
- Hits           56       51       -5     
- Misses          3        8       +5
Flag Coverage Δ
#unittests 86.44% <77.41%> (-8.48%) :arrow_down:
Impacted Files Coverage Δ
etelemetry/client.py 86.53% <77.41%> (-13.47%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab895c7...ed6831f. Read the comment docs.

satra commented 4 years ago

@mgxd - thanks for feedback. if things look ok, do you want to merge and release a new version?