search

sensein / etelemetry-client

Etelemetry client
Other
3 stars 9 forks source link

Network sandboxed tests #41

Closed TheChymera closed 10 months ago

TheChymera commented 1 year ago

I am obviously aware that the package's usage is internet-focused, nevertheless, would it be possible to have more tests providing hopefully a more accurate predictor for the package's ability to function which work inside a network sandbox?

As of 0.3.0 the package has 4 tests, and 3 of them fail with urllib or socket errrors: https://ppb.chymera.eu/e46a99.log

mgxd commented 1 year ago

How about we just mark them to be skipped if no internet connection is available?

TheChymera commented 1 year ago

@mgxd sure, that would help avoid manual skipping, so it's in any case a plus. But more sandboxable tests would also be cool in as far as you're interested or this is at all feasible.