sensein / etelemetry-client

Etelemetry client
Other
3 stars 9 forks source link

Replace `pkg_resources.parse_version` with `packaging.version.Version` #44

Closed jwodder closed 1 year ago

jwodder commented 1 year ago

pkg_resources is deprecated and should no longer be used. This PR replaces the use of pkg_resources.parse_version() with its non-deprecated equivalent, packaging.version.Version.

yarikoptic commented 1 year ago

@satra ping on this PR. May be you could add me and @jwodder to "legit" contributors so at least workflows run without needing to be approved?

codecov[bot] commented 1 year ago

Codecov Report

Merging #44 (65d4237) into master (88adc39) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files           3        3           
  Lines          73       73           
=======================================
  Hits           61       61           
  Misses         12       12           
Flag Coverage Δ
unittests 83.56% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
etelemetry/client.py 82.53% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

satra commented 1 year ago

i have added you as admins.

jwodder commented 1 year ago

@satra The tests are failing because codecov.io is having issues, and then the default fail-fast strategy for Actions matrices is causing all other running tests to be cancelled. I recommend the following:

yarikoptic commented 1 year ago

both sound good to me @jwodder , let's proceed that way

satra commented 1 year ago

released.

effigies commented 1 year ago

Thanks, @satra!