search

sensein / etelemetry-client

Etelemetry client
Other
3 stars 9 forks source link

CI: Build with build #49

Closed effigies closed 9 months ago

effigies commented 10 months ago

Calling python setup.py directly is deprecated. Using a dedicated build tool like build is the thing now. Also switched to pipx to bypass the install step; pipx will ensure the tools we directly use get installed and build will ensure the build-time dependencies get installed.

codecov[bot] commented 10 months ago

Codecov Report

Merging #49 (70c27eb) into master (0d7dbe2) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files           3        3           
  Lines          73       73           
=======================================
  Hits           61       61           
  Misses         12       12
Flag Coverage Δ
unittests 83.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

yarikoptic commented 10 months ago

I trust you on this @effigies ! but now we need a rebase due to dependabot changes have been merged

effigies commented 10 months ago

Would it make sense to run this on all PR/push and just condition the publish step on release?

effigies commented 10 months ago

Did it anyway. Now no need to trust.