sensein / etelemetry-client

Etelemetry client
Other
3 stars 9 forks source link

enh: support disabling ET via an environment variable #6

Closed satra closed 4 years ago

satra commented 4 years ago

thoughts on what the return value should be?

codecov-io commented 4 years ago

Codecov Report

Merging #6 into master will decrease coverage by 1.98%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   97.72%   95.74%   -1.99%     
==========================================
  Files           3        3              
  Lines          44       47       +3     
==========================================
+ Hits           43       45       +2     
- Misses          1        2       +1
Flag Coverage Δ
#unittests 95.74% <66.66%> (-1.99%) :arrow_down:
Impacted Files Coverage Δ
etelemetry/client.py 95.23% <66.66%> (-4.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf70c9b...584c8cc. Read the comment docs.