search

sensein / mapalign

Diffusion map based embedding and alignment
Other
68 stars 28 forks source link

Move transition matrix computation outside of main function #15

Open mfalkiewicz opened 6 years ago

mfalkiewicz commented 6 years ago

Refactoring the kernel normalization and transition matrix computation as independent function will allow for more code re-use.

satra commented 6 years ago

@mfalkiewicz - should #13 still be a PR?

mfalkiewicz commented 6 years ago

@satra: no, I merged them both together and deleted #13.

satra commented 6 years ago

also tests are not passing - since the markov computation has changed.

i would recommend creating a second markov option with your changes, unless you think the current implementation is an error. this will help keep the api consistent. and you can create a new set of embedding tests with the alternate calculation.