Closed wilke0818 closed 1 month ago
Attention: Patch coverage is 84.92176%
with 106 lines
in your changes missing coverage. Please review.
Project coverage is 65.51%. Comparing base (
43f451c
) to head (e95f8ec
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
thank you, @wilke0818; this is great! I have made some changes to align this branch with main
and fixed some formatting.
Some suggestions:
DeviceType
(as in senselab.utils.functions
; actually, we can move this to senselab.utils.device
).
Also, we prefer specifying the device
instead of using use_gpu
(this is not a binary choice; e.g., we do support MPS, too) AudioDataset
class (do we really need it?). I feel we need to discuss this further. And if the answer is yes, can you make it a child class of Pydantic.BaseModel
as you did with Audio
?As a general comment, we have many for
loops, which may be a sign that we still need to work on optimizing the code. will keep this for our discussion later today @wilke0818