search

senseiwells / EssentialClient

EssentialClient is a client side mod originally forked from Carpet Client for 1.15.2 that implements new client side features
MIT License
77 stars 14 forks source link

Suggestion: Make the client prioritise carpet rules available on the client over database #88

Closed ghost closed 1 year ago

ghost commented 1 year ago

Carpet rule allowSpawningOfflinePlayers giving out error when being edited from essential client carpet menu image

Apparently, carpet dosen't have this option while essential client shows it. image image

Isn't it possible to get the possible values from carpet instead of it being hard coded? (in case it is)

senseiwells commented 1 year ago

The reason this happens is because the data for the rules is pulled from the carpet database. This scans all carpet extensions for their rules and their available options. If you are running an older version of carpet mod the options may have changed since then and thus the most updated options won't work. It isn't possible to get the data from carpet, unless you also have carpet installed (and are in singleplayer). I suppose I could implement is so if you have a matching carpet rule from a mod installed it displays correctly...? But for rules that are not present on the client the only source of data for that rule is from the database so it's not possible to fix this.

ghost commented 1 year ago

wait but i have the latest carpet version for 1.19.3

senseiwells commented 1 year ago

Oops, that's my mistake, this was actually an issue with the database (see here). This has now been fixed, so when the database next updates this should be fixed.

However I will leave this issue open as what I previously stated is still valid.