search

sensepost / cipherchecks

visually see issues with supported cipher suites
GNU General Public License v3.0
15 stars 7 forks source link

docker installation and port input parameter #3

Closed OfficialScragg closed 1 year ago

OfficialScragg commented 1 year ago

Made a Dockerfile for easy install and updated the README.md with instructions for getting the image up and running. To execute Cipherchecks in the container you can just execute the cipherchecks script that is in the working directory. Also added a port parameter when executing the script so that you can scan any port on the target not just 443.

jthorpe6 commented 1 year ago

Heya @OfficialScragg thank you !! Don't know why the PR go closed when I changed the Dockerfile.

Typically you dont what to set a timezone in a docker container because you don't know where the user is going to be located in the world. Also, && is your best friend when it comes to docker containers. Each time you have a RUN or top level command in a Docker file, it creates a new delta image, so anything that can be grouped together (such as apt installs) should be.

I also saw you used python3.8 I've never tried the project with that, and was having build issues with python3.8 so I bumped that to python3.9.

OfficialScragg commented 1 year ago

Hi Joe,

Not a problem, got it working yesterday so I thought I should just help everyone else out along the way.

I appreciate the Docker tips, I’ll make sure to do it that way in the future. Just one thing, the reason I used python3.8 is because pip could not find the correct version of the dependencies when I used other versions of Python. I just cloned the repo now and the Dockerfile is currently broken because pip couldn’t find the version of sslyze that your docker was trying to install. I got the best results with sslyze 4.0 and nassl 4.0.1. Got it up and running for a few people with those versions. Maybe we should just switch the versions back and keep your clean formatting. Those dependencies seem super sensitive to versions.

All the best, Daniel

On 19 May 2023, at 12:18, JxTx @.***> wrote:



Heya @OfficialScragghttps://github.com/OfficialScragg thank you !! Don't know why the PR go closed when I changed the Dockerfile.

Typically you dont what to set a timezone in a docker container because you don't know where the user is going to be located in the world. Also, && is your best friend when it comes to docker containers. Each time you have a RUN or top level command in a Docker file, it creates a new delta image, so anything that can be grouped together (such as apt installs) should be.

I also saw you used python3.8 I've never tried the project with that, and was having build issues with python3.8 so I bumped that to python3.9.

— Reply to this email directly, view it on GitHubhttps://github.com/sensepost/cipherchecks/pull/3#issuecomment-1554354043, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AI7CJJWHEUICMYAAJYUBGV3XG5CIZANCNFSM6AAAAAAYHNZ6SI. You are receiving this because you were mentioned.Message ID: @.***>

OfficialScragg commented 1 year ago

Ooooh, I see the problem. You just need to change the Entrypoint to python3.9 as well. Then it works well.

Thanks for the tool.

On 19 May 2023, at 13:55, Daniel Scragg @.***> wrote:

 Hi Joe,

Not a problem, got it working yesterday so I thought I should just help everyone else out along the way.

I appreciate the Docker tips, I’ll make sure to do it that way in the future. Just one thing, the reason I used python3.8 is because pip could not find the correct version of the dependencies when I used other versions of Python. I just cloned the repo now and the Dockerfile is currently broken because pip couldn’t find the version of sslyze that your docker was trying to install. I got the best results with sslyze 4.0 and nassl 4.0.1. Got it up and running for a few people with those versions. Maybe we should just switch the versions back and keep your clean formatting. Those dependencies seem super sensitive to versions.

All the best, Daniel

On 19 May 2023, at 12:18, JxTx @.***> wrote:



Heya @OfficialScragghttps://github.com/OfficialScragg thank you !! Don't know why the PR go closed when I changed the Dockerfile.

Typically you dont what to set a timezone in a docker container because you don't know where the user is going to be located in the world. Also, && is your best friend when it comes to docker containers. Each time you have a RUN or top level command in a Docker file, it creates a new delta image, so anything that can be grouped together (such as apt installs) should be.

I also saw you used python3.8 I've never tried the project with that, and was having build issues with python3.8 so I bumped that to python3.9.

— Reply to this email directly, view it on GitHubhttps://github.com/sensepost/cipherchecks/pull/3#issuecomment-1554354043, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AI7CJJWHEUICMYAAJYUBGV3XG5CIZANCNFSM6AAAAAAYHNZ6SI. You are receiving this because you were mentioned.Message ID: @.***>